Skip to content

make link_llvm_intrinsics and platform_intrinsics features internal #116093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2023
Merged

make link_llvm_intrinsics and platform_intrinsics features internal #116093

merged 2 commits into from
Sep 27, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 23, 2023 •
edited
Loading

These are both a lot like feature(intrinsics), just slightly different syntax, so IMO it should be treated the same (also in terms of: if you get ICEs with this feature, that's on you -- we are not doing "nice" type-checking for intrinsics).

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2023
@RalfJung RalfJung mentioned this pull request Sep 23, 2023
Merged
@RalfJung RalfJung changed the title make link_llvm_intrinsics feature internal make link_llvm_intrinsics and platform_intrinsics features internal Sep 23, 2023
@bjorn3
Copy link
Member

bjorn3 commented Sep 24, 2023

For LLVM intrinsics you wouldn't "just" ICE, you would likely segfault the compiler on incorrect usage.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 27, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 27, 2023

📌 Commit ab83073 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023
@bors
Copy link
Collaborator

bors commented Sep 27, 2023

⌛ Testing commit ab83073 with merge 92009f2...

@bors
Copy link
Collaborator

bors commented Sep 27, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 92009f2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2023
@bors bors merged commit 92009f2 into rust-lang:master Sep 27, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 27, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (92009f2): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.1%, 2.6%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.103s -> 632.158s (0.01%)
Artifact size: 317.29 MiB -> 317.25 MiB (-0.01%)

@RalfJung RalfJung deleted the link_llvm_intrinsics branch September 30, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.
6 participants
@RalfJung @rustbot @bjorn3 @oli-obk @bors @rust-timer